medlogic
/
olivetin
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

gocyclo simplify getButtons

This commit is contained in:
jamesread 2021-10-18 10:26:53 +01:00
parent ddcedb0cf4
commit d7bd0cfe74
1 changed files with 16 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
internal/grpcapi/grpcApi.go
View File

@ -45,11 +45,23 @@ func (api *oliveTinAPI) StartAction(ctx ctx.Context, req *pb.StartActionRequest)
} }
func (api *oliveTinAPI) GetButtons(ctx ctx.Context, req *pb.GetButtonsRequest) (*pb.GetButtonsResponse, error) { func (api *oliveTinAPI) GetButtons(ctx ctx.Context, req *pb.GetButtonsRequest) (*pb.GetButtonsResponse, error) {
res := &pb.GetButtonsResponse{}
user := acl.UserFromContext(ctx) user := acl.UserFromContext(ctx)
for _, action := range cfg.ActionButtons { res := actionButtonsCfgToPb(cfg.ActionButtons, user)
if len(res.Actions) == 0 {
log.Warn("Zero actions found - check that you have some actions defined, with a view permission")
}
log.Debugf("getButtons: %v", res)
return res, nil
}
func actionButtonsCfgToPb(cfgActionButtons []config.ActionButton, user *acl.User) (*pb.GetButtonsResponse) {
res := &pb.GetButtonsResponse{}
for _, action := range cfgActionButtons {
if !acl.IsAllowedView(cfg, user, &action) { if !acl.IsAllowedView(cfg, user, &action) {
continue continue
} }
@ -64,13 +76,7 @@ func (api *oliveTinAPI) GetButtons(ctx ctx.Context, req *pb.GetButtonsRequest) (
res.Actions = append(res.Actions, &btn) res.Actions = append(res.Actions, &btn)
} }
if len(res.Actions) == 0 { return res
log.Warn("Zero actions found - check that you have some actions defined, with a view permission")
}
log.Debugf("getButtons: %v", res)
return res, nil
} }
func (api *oliveTinAPI) GetLogs(ctx ctx.Context, req *pb.GetLogsRequest) (*pb.GetLogsResponse, error) { func (api *oliveTinAPI) GetLogs(ctx ctx.Context, req *pb.GetLogsRequest) (*pb.GetLogsResponse, error) {