medlogic
/
olivetin
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

bugfix: Empty environment variable names causing exec failures on Windows, thanks @sirjmann92 ! (#353)

This commit is contained in:
James Read 2024-07-12 17:22:03 +01:00 committed by GitHub
parent 897cc0e034
commit 9dd33bc3f9
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
internal/executor/executor.go
View File

@ -380,7 +380,14 @@ func buildEnv(req *ExecutionRequest) []string {
ret := append(os.Environ(), "OLIVETIN=1") ret := append(os.Environ(), "OLIVETIN=1")
for k, v := range req.Arguments { for k, v := range req.Arguments {
ret = append(ret, fmt.Sprintf("%v=%v", strings.ToUpper(k), v)) varName := fmt.Sprintf("%v", strings.TrimSpace(strings.ToUpper(k)))
// Skip arguments that might not have a name (eg, confirmation), as this causes weird bugs on Windows.
if varName == "" {
continue
}
ret = append(ret, fmt.Sprintf("%v=%v", varName, v))
} }
return ret return ret