medlogic
/
olivetin
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chore: Fix integration test edge cases in suggestionsBrowserKey

This commit is contained in:
jamesread 2026-01-09 12:23:14 +00:00
parent 661bcdda08
commit 9b1b72773d
2 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
frontend/resources/vue/views/ArgumentForm.vue
View File

@ -339,8 +339,8 @@ function saveBrowserSuggestions() {
if (arg.suggestionsBrowserKey) { if (arg.suggestionsBrowserKey) {
const value = argValues.value[arg.name] const value = argValues.value[arg.name]
// Only save non-empty values for non-checkbox/confirmation types // Only save non-empty values for non-checkbox/confirmation/password types
if (value && value !== '' && arg.type !== 'checkbox' && arg.type !== 'confirmation') { if (value && value !== '' && arg.type !== 'checkbox' && arg.type !== 'confirmation' && arg.type !== 'password') {
try { try {
const key = `olivetin-suggestions-${arg.suggestionsBrowserKey}` const key = `olivetin-suggestions-${arg.suggestionsBrowserKey}`
const stored = localStorage.getItem(key) const stored = localStorage.getItem(key)

11
integration-tests/tests/suggestionsBrowserKey/suggestionsBrowserKey.mjs
View File

@ -222,10 +222,15 @@ describe('config: suggestionsBrowserKey', function () {
await waitForLogsPage() await waitForLogsPage()
await waitForExecutionComplete() await waitForExecutionComplete()
// Verify empty value was not saved - localStorage should be null or not contain the key // Verify empty value was not saved - localStorage should be null or empty-equivalent
const stored = await getLocalStorageItem('olivetin-suggestions-test-suggestions-key') const stored = await getLocalStorageItem('olivetin-suggestions-test-suggestions-key')
// Should be null since empty values are not saved // Should be null OR empty JSON array string ("[]") OR parse to empty array
expect(stored).to.be.null if (stored !== null) {
const suggestions = JSON.parse(stored)
expect(suggestions).to.be.an('array')
expect(suggestions).to.have.length(0)
}
// If stored is null, that's also acceptable - no assertion needed
}) })
it('Suggestions are shared across inputs with the same suggestionsBrowserKey', async function () { it('Suggestions are shared across inputs with the same suggestionsBrowserKey', async function () {