From 7ddc112b2c216df8e67ab1e9f4c7145d29b0e55c Mon Sep 17 00:00:00 2001 From: jamesread Date: Mon, 23 Dec 2024 17:14:55 +0000 Subject: [PATCH] doc: CONTRIBUTING - add more guidelines --- CONTRIBUTING.adoc | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/CONTRIBUTING.adoc b/CONTRIBUTING.adoc index cc13207..d5b94f3 100644 --- a/CONTRIBUTING.adoc +++ b/CONTRIBUTING.adoc @@ -11,6 +11,14 @@ Ideas may be discussed, purely on their merits and issues. Our Code of Conduct discussion throughout the whole process. This project respects the link:https://www.kernel.org/doc/html/latest/process/code-of-conduct.html[Linux Kernel code of conduct]. +== More than 3 lines - talk to someone first + +If you're planning on making a change that's more than a 3 lines, please talk to someone first. This is so that you don't waste your time on something that might not be accepted. It's also a good way to get some feedback on your idea and make sure you're on the right track. + +== A PR should be one logical change + +Please try to keep your pull requests small and focused. It's almost impossible to review PRs that change lots of files for lots of different reasons. If you have a big change, it's probably best to break it down into smaller, more manageable chunks, otherwise it's likely to be rejected. + == If you're not sure, ask! Don't be afraid to ask for advice before working on a