From 62ae4fea2b3e03db0be4ca217ca8d3cfa991fe38 Mon Sep 17 00:00:00 2001 From: jamesread Date: Mon, 13 Jul 2026 22:10:43 +0100 Subject: [PATCH] fix: prefix form arguments to prevent collisions with other page elements --- frontend/package.json | 2 +- .../vue/components/ChoiceChecklist.vue | 23 ++- .../vue/components/ChoiceCombobox.vue | 14 +- .../resources/vue/utils/argumentFieldIds.js | 41 +++++ .../vue/utils/argumentFieldIds.test.mjs | 85 ++++++++++ .../resources/vue/utils/prefilledArguments.js | 11 +- .../vue/utils/prefilledArguments.test.mjs | 45 +++-- frontend/resources/vue/views/ArgumentForm.vue | 23 +-- integration-tests/lib/elements.js | 9 + .../argumentIdCollision.mjs | 154 ++++++++++++++++++ .../tests/argumentIdCollision/config.yaml | 28 ++++ integration-tests/tests/checkbox/checkbox.mjs | 5 +- integration-tests/tests/datetime/datetime.mjs | 7 +- .../suggestionsBrowserKey.mjs | 18 +- 14 files changed, 398 insertions(+), 67 deletions(-) create mode 100644 frontend/resources/vue/utils/argumentFieldIds.js create mode 100644 frontend/resources/vue/utils/argumentFieldIds.test.mjs create mode 100644 integration-tests/tests/argumentIdCollision/argumentIdCollision.mjs create mode 100644 integration-tests/tests/argumentIdCollision/config.yaml diff --git a/frontend/package.json b/frontend/package.json index 6865bb0..bd21edf 100644 --- a/frontend/package.json +++ b/frontend/package.json @@ -10,7 +10,7 @@ "stylelint-config-standard": "^40.0.0" }, "scripts": { - "test": "node --test resources/vue/components/*.test.mjs" + "test": "node --test resources/vue/components/*.test.mjs resources/vue/utils/*.test.mjs" }, "author": "", "parcelIgnore": [ diff --git a/frontend/resources/vue/components/ChoiceChecklist.vue b/frontend/resources/vue/components/ChoiceChecklist.vue index 04235d6..c880a0c 100644 --- a/frontend/resources/vue/components/ChoiceChecklist.vue +++ b/frontend/resources/vue/components/ChoiceChecklist.vue @@ -1,5 +1,5 @@