From 52ff504a9dfe104d742e9a93e22da9f9502ec88c Mon Sep 17 00:00:00 2001
From: jamesread <contact@jread.com>
Date: Mon, 10 Nov 2025 13:21:54 +0000
Subject: [PATCH 1/6] fix: (#704) Confirmation buttons

---
 frontend/resources/vue/views/ArgumentForm.vue | 78 ++++++++++++-------
 1 file changed, 50 insertions(+), 28 deletions(-)

diff --git a/frontend/resources/vue/views/ArgumentForm.vue b/frontend/resources/vue/views/ArgumentForm.vue
index 70f5aca..f5420ec 100644
--- a/frontend/resources/vue/views/ArgumentForm.vue
+++ b/frontend/resources/vue/views/ArgumentForm.vue
@@ -8,29 +8,38 @@
         <template v-if="actionArguments.length > 0">
 
           <template v-for="arg in actionArguments" :key="arg.name" class="argument-group">
-            <label :for="arg.name">
-              {{ formatLabel(arg.title) }}
-            </label>
+            <div v-if="arg.type === 'confirmation'">
+              <label :for="arg.name">
+                {{ formatLabel(arg.title) }}
+              </label>
+              <input :id="arg.name" :name="arg.name" type="checkbox" :checked="getArgumentValue(arg)"
+                @input="handleInput(arg, $event)" @change="handleChange(arg, $event)" />
+            </div>
+            <template v-else>
+              <label :for="arg.name">
+                {{ formatLabel(arg.title) }}
+              </label>
 
-            <datalist v-if="arg.suggestions && Object.keys(arg.suggestions).length > 0" :id="`${arg.name}-choices`">
-              <option v-for="(suggestion, key) in arg.suggestions" :key="key" :value="key">
-                {{ suggestion }}
-              </option>
-            </datalist>
+              <datalist v-if="arg.suggestions && Object.keys(arg.suggestions).length > 0" :id="`${arg.name}-choices`">
+                <option v-for="(suggestion, key) in arg.suggestions" :key="key" :value="key">
+                  {{ suggestion }}
+                </option>
+              </datalist>
 
-            <select v-if="getInputComponent(arg) === 'select'" :id="arg.name" :name="arg.name" :value="getArgumentValue(arg)"
-              :required="arg.required" @input="handleInput(arg, $event)" @change="handleChange(arg, $event)">
-              <option v-for="choice in arg.choices" :key="choice.value" :value="choice.value">
-                {{ choice.title || choice.value }}
-              </option>
-            </select>
-            
-            <component v-else :is="getInputComponent(arg)" :id="arg.name" :name="arg.name" :value="getArgumentValue(arg)"
-              :list="arg.suggestions ? `${arg.name}-choices` : undefined" 
-              :type="getInputComponent(arg) !== 'select' ? getInputType(arg) : undefined"
-              :rows="arg.type === 'raw_string_multiline' ? 5 : undefined"
-              :step="arg.type === 'datetime' ? 1 : undefined" :pattern="getPattern(arg)" :required="arg.required"
-              @input="handleInput(arg, $event)" @change="handleChange(arg, $event)" />
+              <select v-if="getInputComponent(arg) === 'select'" :id="arg.name" :name="arg.name" :value="getArgumentValue(arg)"
+                :required="arg.required" @input="handleInput(arg, $event)" @change="handleChange(arg, $event)">
+                <option v-for="choice in arg.choices" :key="choice.value" :value="choice.value">
+                  {{ choice.title || choice.value }}
+                </option>
+              </select>
+              
+              <component v-else :is="getInputComponent(arg)" :id="arg.name" :name="arg.name" :value="getArgumentValue(arg)"
+                :list="arg.suggestions ? `${arg.name}-choices` : undefined" 
+                :type="getInputComponent(arg) !== 'select' ? getInputType(arg) : undefined"
+                :rows="arg.type === 'raw_string_multiline' ? 5 : undefined"
+                :step="arg.type === 'datetime' ? 1 : undefined" :pattern="getPattern(arg)" :required="arg.required"
+                @input="handleInput(arg, $event)" @change="handleChange(arg, $event)" />
+            </template>
 
             <span class="argument-description" v-html="arg.description"></span>
           </template>
@@ -96,18 +105,27 @@ async function setup() {
 
   // Initialize values from query params or defaults
   actionArguments.value.forEach(arg => {
-    const paramValue = getQueryParamValue(arg.name)
-    argValues.value[arg.name] = paramValue !== null ? paramValue : arg.defaultValue || ''
-
     if (arg.type === 'confirmation') {
       hasConfirmation.value = true
+      const paramValue = getQueryParamValue(arg.name)
+      let checkedValue = false
+      if (paramValue !== null) {
+        checkedValue = paramValue === '1' || paramValue === 'true' || paramValue === true
+      } else if (arg.defaultValue !== undefined && arg.defaultValue !== '') {
+        checkedValue = arg.defaultValue === '1' || arg.defaultValue === 'true' || arg.defaultValue === true
+      }
+      argValues.value[arg.name] = checkedValue
+      confirmationChecked.value = checkedValue
+    } else {
+      const paramValue = getQueryParamValue(arg.name)
+      argValues.value[arg.name] = paramValue !== null ? paramValue : arg.defaultValue || ''
     }
   })
 
   // Run initial validation on all fields after DOM is updated
   await nextTick()
   for (const arg of actionArguments.value) {
-    if (arg.type && !arg.type.startsWith('regex:') && arg.type !== 'select' && arg.type !== '') {
+    if (arg.type && !arg.type.startsWith('regex:') && arg.type !== 'select' && arg.type !== '' && arg.type !== 'confirmation') {
       await validateArgument(arg, argValues.value[arg.name])
     }
   }
@@ -143,6 +161,10 @@ function getInputType(arg) {
     return undefined
   }
 
+  if (arg.type === 'confirmation') {
+    return 'checkbox'
+  }
+
   if (arg.type === 'ascii_identifier') {
     return 'text'
   }
@@ -158,8 +180,8 @@ function getPattern(arg) {
 }
 
 function getArgumentValue(arg) {
-  if (arg.type === 'checkbox') {
-    return argValues.value[arg.name] === '1' || argValues.value[arg.name] === true
+  if (arg.type === 'checkbox' || arg.type === 'confirmation') {
+    return argValues.value[arg.name] === '1' || argValues.value[arg.name] === true || argValues.value[arg.name] === 'true'
   }
   return argValues.value[arg.name] || ''
 }
@@ -240,7 +262,7 @@ function getArgumentValues() {
   for (const arg of actionArguments.value) {
     let value = argValues.value[arg.name] || ''
 
-    if (arg.type === 'checkbox') {
+    if (arg.type === 'checkbox' || arg.type === 'confirmation') {
       value = value ? '1' : '0'
     }
 

From b071b4d0360c84d5424544a7aac6e53d2a9591b0 Mon Sep 17 00:00:00 2001
From: jamesread <contact@jread.com>
Date: Mon, 10 Nov 2025 19:46:08 +0000
Subject: [PATCH 2/6] feat: Increase terminal size, and in fullscreen mode

---
 frontend/resources/vue/views/ExecutionView.vue | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/frontend/resources/vue/views/ExecutionView.vue b/frontend/resources/vue/views/ExecutionView.vue
index 7792601..68a78fd 100644
--- a/frontend/resources/vue/views/ExecutionView.vue
+++ b/frontend/resources/vue/views/ExecutionView.vue
@@ -104,7 +104,7 @@ let terminal = null
 function initializeTerminal() {
   terminal = new OutputTerminal(executionTrackingId.value)
   terminal.open(xtermOutput.value)
-  terminal.resize(80, 24)
+  terminal.resize(80, 40)
 
   window.terminal = terminal
 }
@@ -327,6 +327,17 @@ function goBack() {
 }
 
 onMounted(() => {
+  document.addEventListener('fullscreenchange', (e) => {
+    setTimeout(() => { // Wait for the DOM to settle
+      if (document.fullscreenElement) {
+        window.terminal.fit()
+      } else {
+        window.terminal.resize(80, 40)
+        window.terminal.fit()
+      }
+    }, 100)
+  })
+
   initializeTerminal()
   fetchExecutionResult(props.executionTrackingId)
 

From 263601170f4747e8e857194b75a0d59c4a719a19 Mon Sep 17 00:00:00 2001
From: jamesread <contact@jread.com>
Date: Mon, 10 Nov 2025 19:46:58 +0000
Subject: [PATCH 3/6] fix: (#702) Fixed actions being drawn in a column (an
 extra fieldset was being added)

---
 frontend/resources/vue/components/DashboardComponent.vue | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/frontend/resources/vue/components/DashboardComponent.vue b/frontend/resources/vue/components/DashboardComponent.vue
index 9b981be..0bb848e 100644
--- a/frontend/resources/vue/components/DashboardComponent.vue
+++ b/frontend/resources/vue/components/DashboardComponent.vue
@@ -14,12 +14,9 @@
     </div>
 
     <template v-else-if="component.type == 'fieldset'">
-        <fieldset>
-            <legend>{{ component.title }}</legend>
-            <template v-for="subcomponent in component.contents" :key="subcomponent.title">
-                <DashboardComponent :component="subcomponent" />
-            </template>
-        </fieldset>
+        <template v-for="subcomponent in component.contents" :key="subcomponent.title">
+            <DashboardComponent :component="subcomponent" />
+        </template>
     </template>
 
     <div v-else>

From 32a062ae93f803338f10ce1d7d2c75776a51cb8c Mon Sep 17 00:00:00 2001
From: jamesread <contact@jread.com>
Date: Mon, 10 Nov 2025 20:12:19 +0000
Subject: [PATCH 4/6] fix: (#707) Confirmation buttons and ASCII input types

---
 frontend/resources/vue/views/ArgumentForm.vue | 29 ++-----------------
 1 file changed, 2 insertions(+), 27 deletions(-)

diff --git a/frontend/resources/vue/views/ArgumentForm.vue b/frontend/resources/vue/views/ArgumentForm.vue
index f5420ec..503df8f 100644
--- a/frontend/resources/vue/views/ArgumentForm.vue
+++ b/frontend/resources/vue/views/ArgumentForm.vue
@@ -7,15 +7,7 @@
       <form @submit="handleSubmit">
         <template v-if="actionArguments.length > 0">
 
-          <template v-for="arg in actionArguments" :key="arg.name" class="argument-group">
-            <div v-if="arg.type === 'confirmation'">
-              <label :for="arg.name">
-                {{ formatLabel(arg.title) }}
-              </label>
-              <input :id="arg.name" :name="arg.name" type="checkbox" :checked="getArgumentValue(arg)"
-                @input="handleInput(arg, $event)" @change="handleChange(arg, $event)" />
-            </div>
-            <template v-else>
+          <template v-for="arg in actionArguments" :key="arg.name">
               <label :for="arg.name">
                 {{ formatLabel(arg.title) }}
               </label>
@@ -39,7 +31,6 @@
                 :rows="arg.type === 'raw_string_multiline' ? 5 : undefined"
                 :step="arg.type === 'datetime' ? 1 : undefined" :pattern="getPattern(arg)" :required="arg.required"
                 @input="handleInput(arg, $event)" @change="handleChange(arg, $event)" />
-            </template>
 
             <span class="argument-description" v-html="arg.description"></span>
           </template>
@@ -165,7 +156,7 @@ function getInputType(arg) {
     return 'checkbox'
   }
 
-  if (arg.type === 'ascii_identifier') {
+  if (arg.type === 'ascii_identifier' || arg.type === 'ascii') {
     return 'text'
   }
 
@@ -370,22 +361,6 @@ form {
   grid-template-columns: max-content auto auto;
 }
 
-.argument-group {
-  display: flex;
-  flex-direction: column;
-  gap: 0.25rem;
-}
-
-.argument-group label {
-  font-weight: 500;
-  color: #333;
-}
-
-.argument-group input:invalid,
-.argument-group select:invalid,
-.argument-group textarea:invalid {
-  border-color: #dc3545;
-}
 
 .argument-description {
   font-size: 0.875rem;

From e7d4747727ce0e6d22dafd8d4e94168d56ee0aab Mon Sep 17 00:00:00 2001
From: jamesread <contact@jread.com>
Date: Mon, 10 Nov 2025 20:52:49 +0000
Subject: [PATCH 5/6] chore: fix broken integration test after fieldsets
 changes

---
 integration-tests/test/dashboardsWithBasicFieldsets.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/integration-tests/test/dashboardsWithBasicFieldsets.js b/integration-tests/test/dashboardsWithBasicFieldsets.js
index 0ca179b..c36817a 100644
--- a/integration-tests/test/dashboardsWithBasicFieldsets.js
+++ b/integration-tests/test/dashboardsWithBasicFieldsets.js
@@ -43,7 +43,7 @@ describe('config: dashboards with basic fieldsets', function () {
 
     // Check that we have the expected number of fieldsets
     const allFieldsets = await webdriver.findElements(By.css('fieldset'))
-    expect(allFieldsets).to.have.length(5, 'Expected 5 fieldsets total')
+    expect(allFieldsets).to.have.length(3, 'Expected 3 fieldsets total')
     
     // Check that we have fieldsets with the expected titles
     const fieldsetTitles = []

From 83fe489949d9b45c5643379d59b821ffb917ac7b Mon Sep 17 00:00:00 2001
From: jamesread <contact@jread.com>
Date: Mon, 10 Nov 2025 21:08:34 +0000
Subject: [PATCH 6/6] fix: (#703) Fixed entity fieldsets being drawn in a
 random order

---
 service/internal/api/dashboards.go | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/service/internal/api/dashboards.go b/service/internal/api/dashboards.go
index 28f5c12..c837226 100644
--- a/service/internal/api/dashboards.go
+++ b/service/internal/api/dashboards.go
@@ -89,13 +89,10 @@ func buildDefaultDashboard(rr *DashboardRenderRequest) *apiv1.Dashboard {
 }
 
 func sortActions(components []*apiv1.DashboardComponent) []*apiv1.DashboardComponent {
+	log.Infof("sortActions: %+v", components)
 	sort.Slice(components, func(i, j int) bool {
-		if components[i].Action == nil {
-			return false
-		}
-
-		if components[j].Action == nil {
-			return true
+		if components[i].Action == nil || components[j].Action == nil {
+			return components[i].Title < components[j].Title
 		}
 
 		if components[i].Action.Order == components[j].Action.Order {