medlogic
/
olivetin
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

test: make suggestionsBrowserKey values ascii-safe for CI 

Use alphanumeric-only suggestion strings so runs pass when arguments
default to ascii. Increase logs-page wait; drop unused import.

Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
jamesread 2026-05-11 10:13:12 +01:00
parent f33d764a5f
commit 0bdf4ab3ec
1 changed files with 28 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

55
integration-tests/tests/suggestionsBrowserKey/suggestionsBrowserKey.mjs
View File

@ -5,7 +5,6 @@ import {
getRootAndWait, getRootAndWait,
getActionButton, getActionButton,
takeScreenshotOnFailure, takeScreenshotOnFailure,
getTerminalBuffer,
} from '../../lib/elements.js' } from '../../lib/elements.js'
async function openArgumentForm() { async function openArgumentForm() {
@ -45,7 +44,7 @@ async function waitForLogsPage() {
const url = await webdriver.getCurrentUrl() const url = await webdriver.getCurrentUrl()
return url.includes('/logs/') && !url.endsWith('/logs') return url.includes('/logs/') && !url.endsWith('/logs')
}), }),
5000 15000
) )
} }
@ -115,14 +114,16 @@ describe('config: suggestionsBrowserKey', function () {
it('Submitting form saves value to localStorage', async function () { it('Submitting form saves value to localStorage', async function () {
this.timeout(15000) this.timeout(15000)
// Clear localStorage first // Clear localStorage first
await clearLocalStorage() await clearLocalStorage()
await openArgumentForm() await openArgumentForm()
const input = await getTestInput() const input = await getTestInput()
const testValue = 'test-value-123' // Use default argument type "ascii" (alphanumeric only) so tests pass when
// config does not set a looser type (e.g. CI merge base without type lines).
const testValue = 'testvalue123'
await input.clear() await input.clear()
await input.sendKeys(testValue) await input.sendKeys(testValue)
@ -133,7 +134,7 @@ describe('config: suggestionsBrowserKey', function () {
// Verify value was saved to localStorage // Verify value was saved to localStorage
const stored = await getLocalStorageItem('olivetin-suggestions-test-suggestions-key') const stored = await getLocalStorageItem('olivetin-suggestions-test-suggestions-key')
expect(stored).to.not.be.null expect(stored).to.not.be.null
const suggestions = JSON.parse(stored) const suggestions = JSON.parse(stored)
expect(suggestions).to.be.an('array') expect(suggestions).to.be.an('array')
expect(suggestions).to.include(testValue) expect(suggestions).to.include(testValue)
@ -141,9 +142,9 @@ describe('config: suggestionsBrowserKey', function () {
it('Previously saved values appear in datalist', async function () { it('Previously saved values appear in datalist', async function () {
this.timeout(15000) this.timeout(15000)
// First, save a value to localStorage // First, save a value to localStorage
const testValue = 'saved-suggestion-456' const testValue = 'savedsuggestion456'
await webdriver.executeScript(` await webdriver.executeScript(`
const key = 'olivetin-suggestions-test-suggestions-key'; const key = 'olivetin-suggestions-test-suggestions-key';
localStorage.setItem(key, JSON.stringify(['${testValue}'])); localStorage.setItem(key, JSON.stringify(['${testValue}']));
@ -173,7 +174,7 @@ describe('config: suggestionsBrowserKey', function () {
it('Multiple submissions accumulate suggestions', async function () { it('Multiple submissions accumulate suggestions', async function () {
this.timeout(20000) this.timeout(20000)
// Clear localStorage first // Clear localStorage first
await clearLocalStorage() await clearLocalStorage()
@ -181,7 +182,7 @@ describe('config: suggestionsBrowserKey', function () {
await openArgumentForm() await openArgumentForm()
const input1 = await getTestInput() const input1 = await getTestInput()
await input1.clear() await input1.clear()
await input1.sendKeys('first-value') await input1.sendKeys('firstvalue')
await submitForm() await submitForm()
await waitForLogsPage() await waitForLogsPage()
await waitForExecutionComplete() await waitForExecutionComplete()
@ -190,7 +191,7 @@ describe('config: suggestionsBrowserKey', function () {
await openArgumentForm() await openArgumentForm()
const input2 = await getTestInput() const input2 = await getTestInput()
await input2.clear() await input2.clear()
await input2.sendKeys('second-value') await input2.sendKeys('secondvalue')
await submitForm() await submitForm()
await waitForLogsPage() await waitForLogsPage()
await waitForExecutionComplete() await waitForExecutionComplete()
@ -198,17 +199,17 @@ describe('config: suggestionsBrowserKey', function () {
// Verify both values are in localStorage // Verify both values are in localStorage
const stored = await getLocalStorageItem('olivetin-suggestions-test-suggestions-key') const stored = await getLocalStorageItem('olivetin-suggestions-test-suggestions-key')
expect(stored).to.not.be.null expect(stored).to.not.be.null
const suggestions = JSON.parse(stored) const suggestions = JSON.parse(stored)
expect(suggestions).to.be.an('array') expect(suggestions).to.be.an('array')
expect(suggestions).to.include('first-value') expect(suggestions).to.include('firstvalue')
expect(suggestions).to.include('second-value') expect(suggestions).to.include('secondvalue')
expect(suggestions[0]).to.equal('second-value') // Most recent should be first expect(suggestions[0]).to.equal('secondvalue') // Most recent should be first
}) })
it('Empty values are not saved to localStorage', async function () { it('Empty values are not saved to localStorage', async function () {
this.timeout(15000) this.timeout(15000)
// Clear localStorage first // Clear localStorage first
await clearLocalStorage() await clearLocalStorage()
@ -235,7 +236,7 @@ describe('config: suggestionsBrowserKey', function () {
it('Suggestions are shared across inputs with the same suggestionsBrowserKey', async function () { it('Suggestions are shared across inputs with the same suggestionsBrowserKey', async function () {
this.timeout(20000) this.timeout(20000)
// Clear localStorage first // Clear localStorage first
await clearLocalStorage() await clearLocalStorage()
@ -243,14 +244,14 @@ describe('config: suggestionsBrowserKey', function () {
await openArgumentForm() await openArgumentForm()
const input1 = await getTestInput() const input1 = await getTestInput()
await input1.clear() await input1.clear()
await input1.sendKeys('shared-value-from-input1') await input1.sendKeys('sharedfrominput1')
await submitForm() await submitForm()
await waitForLogsPage() await waitForLogsPage()
await waitForExecutionComplete() await waitForExecutionComplete()
// Open the form again and verify the value appears in both datalists // Open the form again and verify the value appears in both datalists
await openArgumentForm() await openArgumentForm()
// Check first input's datalist // Check first input's datalist
const datalist1 = await webdriver.findElement(By.id('testInput-choices')) const datalist1 = await webdriver.findElement(By.id('testInput-choices'))
expect(datalist1).to.not.be.null expect(datalist1).to.not.be.null
@ -258,7 +259,7 @@ describe('config: suggestionsBrowserKey', function () {
let foundInInput1 = false let foundInInput1 = false
for (const option of options1) { for (const option of options1) {
const value = await option.getAttribute('value') const value = await option.getAttribute('value')
if (value === 'shared-value-from-input1') { if (value === 'sharedfrominput1') {
foundInInput1 = true foundInInput1 = true
break break
} }
@ -272,7 +273,7 @@ describe('config: suggestionsBrowserKey', function () {
let foundInInput2 = false let foundInInput2 = false
for (const option of options2) { for (const option of options2) {
const value = await option.getAttribute('value') const value = await option.getAttribute('value')
if (value === 'shared-value-from-input1') { if (value === 'sharedfrominput1') {
foundInInput2 = true foundInInput2 = true
break break
} }
@ -282,24 +283,24 @@ describe('config: suggestionsBrowserKey', function () {
// Now submit a value using the second input // Now submit a value using the second input
const input2 = await getTestInput2() const input2 = await getTestInput2()
await input2.clear() await input2.clear()
await input2.sendKeys('shared-value-from-input2') await input2.sendKeys('sharedfrominput2')
await submitForm() await submitForm()
await waitForLogsPage() await waitForLogsPage()
await waitForExecutionComplete() await waitForExecutionComplete()
// Verify both values appear in both datalists // Verify both values appear in both datalists
await openArgumentForm() await openArgumentForm()
// Check that both values are in the first input's datalist // Check that both values are in the first input's datalist
const options1After = await getDatalistOptions('testInput') const options1After = await getDatalistOptions('testInput')
let foundValue1 = false let foundValue1 = false
let foundValue2 = false let foundValue2 = false
for (const option of options1After) { for (const option of options1After) {
const value = await option.getAttribute('value') const value = await option.getAttribute('value')
if (value === 'shared-value-from-input1') { if (value === 'sharedfrominput1') {
foundValue1 = true foundValue1 = true
} }
if (value === 'shared-value-from-input2') { if (value === 'sharedfrominput2') {
foundValue2 = true foundValue2 = true
} }
} }
@ -312,10 +313,10 @@ describe('config: suggestionsBrowserKey', function () {
foundValue2 = false foundValue2 = false
for (const option of options2After) { for (const option of options2After) {
const value = await option.getAttribute('value') const value = await option.getAttribute('value')
if (value === 'shared-value-from-input1') { if (value === 'sharedfrominput1') {
foundValue1 = true foundValue1 = true
} }
if (value === 'shared-value-from-input2') { if (value === 'sharedfrominput2') {
foundValue2 = true foundValue2 = true
} }
} }